Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Us 2721 performance #3447

Merged
merged 4 commits into from
Sep 27, 2023
Merged

Us 2721 performance #3447

merged 4 commits into from
Sep 27, 2023

Conversation

jma
Copy link
Contributor

@jma jma commented Aug 30, 2023

Why are you opening this PR?

  • Which task/US does it implement?
  • Which issue does it fix?

Dependencies

My PR depends on the following rero-ils-ui's PR(s):

  • rero/rero-ils-ui#

How to test?

  • What command should I have to run to test your PR?
  • What should I test through the UI?

@github-actions github-actions bot added the f: circulation Concerns the circulation interface or backend label Aug 30, 2023
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Aug 31, 2023 •
edited by jma
Loading

jma added 3 commits September 11, 2023 14:00
@jma
circulation: optimize the response time
56da678 
* Removes useless informations.
* Optimizes the computation of the additional informations.
* Create dumper classes for items and loans.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma
circulation: adds availibility API
f9b07c0 
* Adds holding availibility API.
* Uniformize documents and items availibility API.
* Removes availibity from the documents, holdings and items JSON serializers.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma
document: add text for the partOf
4ccdc60 
* Adds a text version of the partOf document as done in the list of results.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the US-2721-performance branch 2 times, most recently from d94d9b9 to 15e6480 Compare September 12, 2023 08:38
@jma jma marked this pull request as ready for review September 12, 2023 08:38
@ManaDeweerdt
Copy link
Contributor

ManaDeweerdt commented Sep 20, 2023 •
edited by PascalRepond
Loading

  • Documents without holdings should be displayed as 'not available' (professional and public view)
  • Documents with an item type categorised as unavailable (ex missing) should be displayed as 'not available'.
  • Fees view not displayed correctly. ERROR TypeError: Cannot read properties of null (reading 'title')
  • REP 25.09: An item that is requested shows a red dot with the item status but it doesn't show anymore the number of requests to explain the red dot (MD: Note: on the item detail view of our production site, the number of request is not visible).
    image

@jma
documents: optimize availability
85c8e21 
- Uses Elasticsearch to compute the documents, items and holdings availability.
- Search only one organisation when an organisation is retrived using a view code.
- Renames the available property for items and holdings into a `is_available` method.

Co-Authored-by: Johnny Mariéthoz <[email protected]>
@jma jma force-pushed the US-2721-performance branch from 15e6480 to 85c8e21 Compare September 25, 2023 09:54
@jma jma merged commit 8bbc162 into staging Sep 27, 2023
5 checks passed
@PascalRepond PascalRepond deleted the US-2721-performance branch February 28, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
f: circulation Concerns the circulation interface or backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jma @ManaDeweerdt